Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add method to obtain revocation status as string(s) #4429

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Adds a method getRevocationStatus to the RevocationServiceRegistry

Why it does that

IdentityHub requires the status as string, not only whether it's valid or not. With BitStringStatusList, there could be custom status fields that are not null, but still indicate success.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Aug 22, 2024
@paullatzelsperger paullatzelsperger merged commit b5c1406 into eclipse-edc:main Aug 23, 2024
21 checks passed
@paullatzelsperger paullatzelsperger deleted the chore/add_method_to_statusservice_registry branch August 23, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants