Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds flag to enable validation on create/update policy definitions #4621

Conversation

wolf4ood
Copy link
Contributor

What this PR changes/adds

adds a configuration edc.policy.validation.enabled for enabling the call to PolicyEngine#validate while creating/updating the PolicyDefinition

Why it does that

improves policy management

Further notes

Renamed also the failure message from left operand to leftOperand for consistency

Linked Issue(s)

Closes #4619

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood self-assigned this Nov 13, 2024
@wolf4ood wolf4ood added the enhancement New feature or request label Nov 13, 2024
@wolf4ood wolf4ood force-pushed the feat/4619_configurable_policy_def_validation branch from 94c655b to 4ea6f56 Compare November 13, 2024 11:24
@wolf4ood wolf4ood force-pushed the feat/4619_configurable_policy_def_validation branch from 4ea6f56 to 5c10e44 Compare November 13, 2024 11:42
@wolf4ood wolf4ood marked this pull request as ready for review November 13, 2024 12:00
…ava/org/eclipse/edc/connector/controlplane/services/ControlPlaneServicesExtension.java

Co-authored-by: andrea bertagnolli <andrea.bertagnolli@gmail.com>
@wolf4ood wolf4ood merged commit fdf6427 into eclipse-edc:main Nov 13, 2024
21 checks passed
@wolf4ood wolf4ood deleted the feat/4619_configurable_policy_def_validation branch November 13, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable policy definition validation
3 participants