Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add decision record for HashiCorp vault authentication refactoring #4802

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

ronjaquensel
Copy link
Contributor

What this PR changes/adds

Adds a decision record about refactoring the HashiCorp vault implementation to support different methods of authentication.

Why it does that

At the moment, only one method of authentication is provided. This should be extensible to support the usage of HashiCorp vault in different deployments and setups.

Who will sponsor this feature?

me

Linked Issue(s)

Closes #4672

Supersedes #4720

Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronjaquensel ronjaquensel force-pushed the vault-authentication-dr branch from 1cb2e97 to 1c4df2d Compare February 10, 2025 08:46
@ronjaquensel ronjaquensel merged commit c726579 into eclipse-edc:main Feb 10, 2025
4 checks passed
@ronjaquensel ronjaquensel deleted the vault-authentication-dr branch February 10, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: HashiCorp Vault authentication refactor decision record
4 participants