Make static variables final

eclipse-edc · Jul 28, 2022 · 0222032 · 0222032
1 parent 9e84010
commit 0222032
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/...java/org/eclipse/dataspaceconnector/identityhub/cli/VerifiableCredentialsCommandTest.java b/...java/org/eclipse/dataspaceconnector/identityhub/cli/VerifiableCredentialsCommandTest.java
@@ -55,7 +55,7 @@ class VerifiableCredentialsCommandTest {
     private static final SignedJWT SIGNED_VC1 = signVerifiableCredential(VC1);
     private static final VerifiableCredential VC2 = createVerifiableCredential();
     private static final SignedJWT SIGNED_VC2 = signVerifiableCredential(VC2);
-    private static String HUB_URL = FAKER.internet().url();
+    private static final String HUB_URL = FAKER.internet().url();
 
     private IdentityHubCli app = new IdentityHubCli();
     private CommandLine cmd = new CommandLine(app);

diff --git a/...va/org/eclipse/dataspaceconnector/identityhub/verifier/DidJwtCredentialsVerifierTest.java b/...va/org/eclipse/dataspaceconnector/identityhub/verifier/DidJwtCredentialsVerifierTest.java
@@ -42,12 +42,12 @@ public class DidJwtCredentialsVerifierTest {
 
     private static final Faker FAKER = new Faker();
     private static final Monitor MONITOR = new ConsoleMonitor();
-    private static ECKey JWK = generateEcKey();
-    private static ECKey ANOTHER_JWK = generateEcKey();
-    private static String ISSUER = FAKER.internet().url();
-    private static String SUBJECT = FAKER.internet().url();
-    private static String OTHER_SUBJECT = FAKER.internet().url() + "other";
-    private static SignedJWT JWT = buildSignedJwt(generateVerifiableCredential(), ISSUER, SUBJECT, JWK);
+    private static final ECKey JWK = generateEcKey();
+    private static final ECKey ANOTHER_JWK = generateEcKey();
+    private static final String ISSUER = FAKER.internet().url();
+    private static final String SUBJECT = FAKER.internet().url();
+    private static final String OTHER_SUBJECT = FAKER.internet().url() + "other";
+    private static final SignedJWT JWT = buildSignedJwt(generateVerifiableCredential(), ISSUER, SUBJECT, JWK);
     private DidPublicKeyResolver didPublicKeyResolver = mock(DidPublicKeyResolver.class);
     private DidJwtCredentialsVerifier didJwtCredentialsVerifier = new DidJwtCredentialsVerifier(didPublicKeyResolver, MONITOR);
 

diff --git a/...g/eclipse/dataspaceconnector/identityhub/verifier/IdentityHubCredentialsVerifierTest.java b/...g/eclipse/dataspaceconnector/identityhub/verifier/IdentityHubCredentialsVerifierTest.java
@@ -50,11 +50,11 @@ public class IdentityHubCredentialsVerifierTest {
 
     private static final Faker FAKER = new Faker();
     private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
-    private static String HUB_BASE_URL = "https://" + FAKER.internet().url();
-    private static DidDocument DID_DOCUMENT = DidDocument.Builder.newInstance()
+    private static final String HUB_BASE_URL = "https://" + FAKER.internet().url();
+    private static final DidDocument DID_DOCUMENT = DidDocument.Builder.newInstance()
             .service(List.of(new Service("IdentityHub", "IdentityHub", HUB_BASE_URL))).build();
-    private static String ISSUER = FAKER.internet().url();
-    private static String SUBJECT = FAKER.internet().url();
+    private static final String ISSUER = FAKER.internet().url();
+    private static final String SUBJECT = FAKER.internet().url();
     private Monitor monitorMock = mock(Monitor.class);
     private IdentityHubClient identityHubClientMock = mock(IdentityHubClient.class);
     private JwtCredentialsVerifier jwtCredentialsVerifierMock = mock(JwtCredentialsVerifier.class);