Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity Hub: CredentialsVerifier #10

Merged

Conversation

marcgs
Copy link
Contributor

@marcgs marcgs commented Jul 25, 2022

What this PR changes/adds

Added IdentityHubCredentialsVerifier: Get credentials from IdentityHub, verify that it is signed by the issuer indicated in the JWT. Updated IdentityHubClient contract accordingly.

Most of the changes outside of this module are there to adapt the code to the new contract: Using SignedJWT instead of serialized VerifiableCredential.

Why it does that

Before applying policies, verifiable credentials need to be retrieved from IdentityHub.

Further notes

  • Updated IdentityHubClient contract to use a JWS. This explains the changes in identity-hub-client and extensions/identity-hub.
  • Added VerifiableCredentialTestUtil to generate VerifiableCredentials and sign them.

Linked Issue(s)

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@marcgs marcgs self-assigned this Jul 25, 2022
@marcgs marcgs force-pushed the feature/24-get-verified-credentials branch from a894816 to c79f08f Compare July 25, 2022 20:11
@marcgs marcgs force-pushed the feature/24-get-verified-credentials branch from c79f08f to 83d387c Compare July 25, 2022 20:12
@paullatzelsperger paullatzelsperger merged commit 57c7c3d into eclipse-edc:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants