-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identity Hub: CredentialsVerifier #10
Merged
paullatzelsperger
merged 127 commits into
eclipse-edc:main
from
agera-edc:feature/24-get-verified-credentials
Jul 25, 2022
Merged
Identity Hub: CredentialsVerifier #10
paullatzelsperger
merged 127 commits into
eclipse-edc:main
from
agera-edc:feature/24-get-verified-credentials
Jul 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aspaceconnector/identityhub/verifier/JwtCredentialsVerifier.java Co-authored-by: Alexandre Gattiker <algattik@users.noreply.github.com>
did: Added IdentityHubCredentialsVerifier
paullatzelsperger
approved these changes
Jul 25, 2022
marcgs
force-pushed
the
feature/24-get-verified-credentials
branch
from
July 25, 2022 20:11
a894816
to
c79f08f
Compare
marcgs
force-pushed
the
feature/24-get-verified-credentials
branch
from
July 25, 2022 20:12
c79f08f
to
83d387c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Added IdentityHubCredentialsVerifier: Get credentials from IdentityHub, verify that it is signed by the issuer indicated in the JWT. Updated IdentityHubClient contract accordingly.
Most of the changes outside of this module are there to adapt the code to the new contract: Using SignedJWT instead of serialized VerifiableCredential.
Why it does that
Before applying policies, verifiable credentials need to be retrieved from IdentityHub.
Further notes
Linked Issue(s)
Checklist
no-changelog
)