Identity Hub: Fix VerifiableCredentialsJwtServiceImpl's "NotSuchMethodError" (#43) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix NoSuchMethodError in VerifiableCredentialsJwtServiceImpl. Add more logging.
7 tasks
...java/org/eclipse/dataspaceconnector/identityhub/verifier/IdentityHubCredentialsVerifier.java
Outdated
Show resolved
Hide resolved
|
|
||
| var claims = successfulResults.stream() | ||
| if (!failedResults.isEmpty()) { |
There was a problem hiding this comment.
This is dangerous: what if a dataspace requires that all claims must be verified? Maybe you could introduce a VerificationResult as a subclass of AbstractResult, that allows for transporting both the successful claims, and the failed ones? That way, the caller of the verifyCredentials method could decide.
There was a problem hiding this comment.
--> will be done in another issue/PR
There was a problem hiding this comment.
As discussed, this will be tackled in a separate story: agera-edc#47. This behaviour was not changed with the current PR.
paullatzelsperger
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Introduce a fix for the "NoSuchMethodError" observed in the CI pipeline for the cloud system tests: https://github.com/agera-edc/MinimumViableDataspace/runs/7693917471?check_suite_focus=true
The cause of the issue is still unclear. It seems that the
toJSONObjectmethod is not available due to a version mismatch of the nimbus library. This does not happen when running tests locally, nor when running the local system tests in CI. Why this only manifests when running the cloud system tests in CI is still a mystery.This PR introduces a workaround by adapting the
VerifiableCredentialsJwtServiceImplnot to use this method.Logging was improved in order to debug the issue and this PR contains additional logging statements that proved to be useful.
Why it does that
Fix Identity Hub integration in MVD.
Linked Issue(s)
Relates to #21
Checklist
no-changelog)