refactor: separate sql stores from datasources #417
Conversation
ndr-brt
added
the
refactoring
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -66,6 +71,7 @@ | |||
| } | |||
|
|
|||
| private String getDataSourceName(ServiceExtensionContext context) { | |||
| return context.getConfig().getString(DATASOURCE_SETTING_NAME, DataSourceRegistry.DEFAULT_DATASOURCE); | |||
| return DataSourceName.getDataSourceName(DATASOURCE_NAME, DATASOURCE_SETTING_NAME, context.getConfig(), context.getMonitor()); | |||
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| @@ -66,6 +70,6 @@ | |||
| } | |||
|
|
|||
| private String getDataSourceName(ServiceExtensionContext context) { | |||
| return context.getConfig().getString(DATASOURCE_SETTING_NAME, DataSourceRegistry.DEFAULT_DATASOURCE); | |||
| return DataSourceName.getDataSourceName(DATASOURCE_NAME, DATASOURCE_SETTING_NAME, context.getConfig(), context.getMonitor()); | |||
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| @@ -76,6 +80,6 @@ | |||
| } | |||
|
|
|||
| private String getDataSourceName(ServiceExtensionContext context) { | |||
| return context.getConfig().getString(DATASOURCE_SETTING_NAME, DataSourceRegistry.DEFAULT_DATASOURCE); | |||
| return DataSourceName.getDataSourceName(DATASOURCE_NAME, DATASOURCE_SETTING_NAME, context.getConfig(), context.getMonitor()); | |||
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| @@ -66,6 +70,6 @@ | |||
| } | |||
|
|
|||
| private String getDataSourceName(ServiceExtensionContext context) { | |||
| return context.getConfig().getString(DATASOURCE_SETTING_NAME, DataSourceRegistry.DEFAULT_DATASOURCE); | |||
| return DataSourceName.getDataSourceName(DATASOURCE_NAME, DATASOURCE_SETTING_NAME, context.getConfig(), context.getMonitor()); | |||
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
ndr-brt
force-pushed
the
416-separate-stores-from-datasources
branch
from
1374eac to
2e06344
Compare
| @Setting(value = "Datasource name for the DidResource database", defaultValue = DataSourceRegistry.DEFAULT_DATASOURCE) | ||
| public static final String DATASOURCE_SETTING_NAME = "edc.datasource.credentials.name"; | ||
| @Setting(value = "The datasource to be used", defaultValue = DataSourceRegistry.DEFAULT_DATASOURCE) |
There was a problem hiding this comment.
nit: i would call the deprecated property DATASOURCE_SETTING_NAME_DEPRECATED, and the new one DATASOURCE_SETTING_NAME
There was a problem hiding this comment.
unfortunately I didn't do that in other repositories so I this point I would just let it like this, anyway I think that the @Deprecated annotation should be enough
What this PR changes/adds
Separate datasource from sql store configurations
Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #416
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.