Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check if DID exists before creating a participant #429

Merged

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Aug 22, 2024

What this PR changes/adds

defensively checks if another ParticipantContext already exists with the same DID when creating ParticipantContexts

Why it does that

defensive checks are better than relying on the database operation failing with a PK violation

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Aug 22, 2024
@paullatzelsperger paullatzelsperger force-pushed the feat/check_if_did_exists branch from ea4b225 to 87d4237 Compare August 23, 2024 07:39
@paullatzelsperger paullatzelsperger marked this pull request as ready for review August 23, 2024 07:41
@paullatzelsperger paullatzelsperger force-pushed the feat/check_if_did_exists branch from e2b0836 to deb11ff Compare August 23, 2024 08:05
@paullatzelsperger paullatzelsperger merged commit f11d504 into eclipse-edc:main Aug 26, 2024
14 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/check_if_did_exists branch August 26, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants