chore: align deleteParticipantContext with DR #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmarino
approved these changes
Sep 9, 2024
wolf4ood
approved these changes
Sep 9, 2024
paullatzelsperger
deleted the
chore/align_ih_with_dr_updateParticipant
branch
paullatzelsperger
restored the
chore/align_ih_with_dr_updateParticipant
branch
paullatzelsperger
deleted the
chore/align_ih_with_dr_updateParticipant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Aligns the code base with this decision-record, specifically the delete-participant action.
In doing so, the following changes were made
new event type
ParticipantContextDeletingwas introduced to signal an impending deletion. This event is consumed by theParticipantContextEventCoordinatorthat triggers theDidDocumentServiceto unpublish and delete the DID Docs, and theKeyPairServiceto revoke the key.the
DidDocumentServicedoes not consume theParticipantContextDeletedevent anymore, because it gets invoked directly by the coordinatorKeyPairServiceImpl: added transaction contextunpublishing DIDs: the check if a DidDocument is in
PUBLISHEDstate was moved from the publisher to theDidDocumentServiceWhy it does that
alignment with the decision decision-records
Further notes
other changes in the PR may not yet correctly reflect other sections of the D-R, those will get refactored in subsequent PRs.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.