Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align activate-key with D-R #451

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Sep 11, 2024

What this PR changes/adds

Aligns the "active-key" operation with the decision record

Why it does that

Briefly state why the change was necessary.

Further notes

  • adds the KeyPairActivated event (and associated methods), which is consumed by the DidDocumentService
  • adds a keyContext field to the KeyPairResource (and the associated DB schema) to track the "context" of the key, e.g. "JsonWebKey2020"
  • renames KeyPairStates#ACTIVE to KeyPairStates#ACTIVATED for consistency
  • the PArticipantContextEventCoordinator emits a warning log if a participant is added and activated, but its only key is in the "inactive" state
  • KeyPairService: when a key is added in the active state, the activateKey method is invoked in the same transaction
  • DidDocumentService reacts to the KeyPairActivated event instead of KeyPairAdded

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

add KeyPairResource to DidDocument only upon activation

fix tests
@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Sep 11, 2024
@paullatzelsperger paullatzelsperger merged commit 64cc36c into eclipse-edc:main Sep 11, 2024
18 checks passed
@paullatzelsperger paullatzelsperger deleted the chore/align_activate-key_with_dr branch September 11, 2024 07:57
ligaz added a commit to ligaz/MinimumViableDataspace that referenced this pull request Sep 12, 2024
paullatzelsperger pushed a commit to eclipse-edc/MinimumViableDataspace that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants