Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(identityHub): module refactor #53

Merged
merged 1 commit into from
Nov 4, 2022
Merged

feat(identityHub): module refactor #53

merged 1 commit into from
Nov 4, 2022

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Oct 31, 2022 •
edited
Loading

What this PR changes/adds

  • Renamed identity-hub-core -> core
  • Created identity-hub-client-spi under spi for IdentityHubClient interface
  • Moved extensions:identity-hub into core:identity-hub
  • Created extensions::identity-hub-api for IdentityHub controllers
  • Moved MessageProcessor interface into identity-hub-spi
  • Moved identity-hub-model into identity-hub-spi and removed the entire module

Why it does that

Module refactor for keeping the repo consistent with EDC

Linked Issue(s)

Closes #48

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@wolf4ood wolf4ood force-pushed the refactor/48_module_reorganize branch 4 times, most recently from e8e6a1d to 78b4d17 Compare November 2, 2022 08:40
@wolf4ood wolf4ood force-pushed the refactor/48_module_reorganize branch from 78b4d17 to 6164631 Compare November 2, 2022 08:54
@wolf4ood wolf4ood marked this pull request as ready for review November 2, 2022 09:06
@bscholtes1A bscholtes1A merged commit cf77ade into eclipse-edc:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bscholtes1A bscholtes1A bscholtes1A approved these changes

@paullatzelsperger paullatzelsperger paullatzelsperger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-organize modules
3 participants
@wolf4ood @paullatzelsperger @bscholtes1A