Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes last @EdcSetting #57

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

wolf4ood
Copy link
Contributor

What this PR changes/adds

Remove the last @EdcSetting

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@wolf4ood wolf4ood self-assigned this Nov 17, 2022
@wolf4ood wolf4ood added the refactoring Changing directories, modules, structures, etc. without functional changes label Nov 17, 2022
@wolf4ood wolf4ood changed the title chore: removed last @EdcSetting chore: removes last @EdcSetting Nov 17, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 62.99% // Head: 62.99% // No change to project coverage 👍

Coverage data is based on head (3c93a71) compared to base (963bbd4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   62.99%   62.99%           
=======================================
  Files          42       42           
  Lines         635      635           
  Branches       22       22           
=======================================
  Hits          400      400           
  Misses        230      230           
  Partials        5        5           
Impacted Files Coverage Δ
...e/edc/identityhub/api/IdentityHubApiExtension.java 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wolf4ood wolf4ood requested a review from jimmarino November 17, 2022 14:33
@jimmarino jimmarino merged commit 67b4ea7 into eclipse-edc:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Changing directories, modules, structures, etc. without functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants