refactor(buid): apply the edc build plugin and the version catalog #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
refactor/56_use_edc_build_plugin
branch
2 times, most recently
from
98df0a1 to
c001b8f
Compare
wolf4ood
added
the
refactoring
wolf4ood
force-pushed
the
refactor/56_use_edc_build_plugin
branch
from
c001b8f to
9254f17
Compare
paullatzelsperger
approved these changes
Nov 18, 2022
bscholtes1A
reviewed
Nov 21, 2022
settings.gradle.kts
Outdated
| versionCatalogs { | ||
| create("libs") { | ||
| from("org.eclipse.edc:edc-versions:0.0.1-SNAPSHOT") | ||
| version("picocli", "4.6.3") |
There was a problem hiding this comment.
Not possible to have these lib versions in the gradle.properties file?
There was a problem hiding this comment.
I tried on top level of the file and it didn't work. Checking it now probably it would work inside the single block
There was a problem hiding this comment.
In case i will raise an issue for fixing this
There was a problem hiding this comment.
I though this was merged, it's still opened so i will change it here
bscholtes1A
approved these changes
Nov 21, 2022
wolf4ood
force-pushed
the
refactor/56_use_edc_build_plugin
branch
from
9254f17 to
1a6753b
Compare
bscholtes1A
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Apply the edc build plugin and the version catalog
Why it does that
simplify build file and consistency with EDC
Linked Issue(s)
Closes #56
Checklist
no-changelog)