refactor(identityHub): client and verifier abstraction over the VC format #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
added
enhancement
wolf4ood
force-pushed
the
feat/75_refactor_client_and_verifier
branch
from
a5acf01 to
da036cd
Compare
|
This pull request is stale because it has been open for 7 days with no activity. |
bscholtes1A
requested changes
Jan 2, 2023
...ntity-hub-client/src/main/java/org/eclipse/edc/identityhub/client/IdentityHubClientImpl.java
Show resolved
Hide resolved
...erifier/src/main/java/org/eclipse/edc/identityhub/verifier/CredentialsVerifierExtension.java
Outdated
Show resolved
Hide resolved
...erifier/src/main/java/org/eclipse/edc/identityhub/verifier/CredentialsVerifierExtension.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/eclipse/edc/identityhub/verifier/DefaultCredentialVerifierRegistry.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/edc/identityhub/spi/credentials/verifier/CredentialVerifierRegistry.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/eclipse/edc/identityhub/verifier/jwt/JwtCredentialsVerifierExtension.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/eclipse/edc/identityhub/verifier/jwt/JwtCredentialsVerifierExtension.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/eclipse/edc/identityhub/verifier/jwt/JwtCredentialsVerifierExtension.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/eclipse/edc/identityhub/verifier/jwt/JwtCredentialsVerifierExtension.java
Show resolved
Hide resolved
...lipse/edc/identityhub/spi/credentials/transformer/CredentialEnvelopeTransformerRegistry.java
Outdated
Show resolved
Hide resolved
bscholtes1A
reviewed
Jan 2, 2023
core/identity-hub/src/main/java/org/eclipse/edc/identityhub/IdentityHubExtension.java
Show resolved
Hide resolved
bscholtes1A
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Refactor the
IdentityHubClientandIdentityHubCredentialsVerifierWhy it does that
Support different VC format
Further notes
For abstracting the format when storing and verifying VC in different format a concept of
CredentialEnvelopehas been introduced in SPI. Which basically carries different implementation/format for Verifiable credentials.On top of that two main interfaces are introduced in order to parse/serialize
CredentialEnvelopeand for verifying the content of aCredentialEnvelopModule refactor:
identity-hub-verifier: moved to core and now contains only the logic for verifying credentials without specific format.identity-hub-credentials-jwt: Jwt implementation of verifiable credentialsidentity-hub-verifier-jwt: credentials verifier that works with Jwt formatLinked Issue(s)
Closes #75
Checklist
no-changelog)