Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(SqlIdentityHubStore): apply AbstractSqlStore class and PostgresqlStoreSetupExtension in test #80

Merged
merged 1 commit into from
Jan 4, 2023
Merged

refactor(SqlIdentityHubStore): apply AbstractSqlStore class and PostgresqlStoreSetupExtension in test #80

merged 1 commit into from
Jan 4, 2023

Conversation

bscholtes1A
Copy link
Contributor

What this PR changes/adds

Apply AbstractSqlStore class and PostgresqlStoreSetupExtension in test.

Why it does that

Code simplification.

Linked Issue(s)

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@bscholtes1A bscholtes1A added the refactoring Changing directories, modules, structures, etc. without functional changes label Jan 3, 2023
@bscholtes1A bscholtes1A requested a review from wolf4ood January 3, 2023 09:00
@bscholtes1A bscholtes1A merged commit c4093fb into eclipse-edc:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf4ood wolf4ood wolf4ood approved these changes

Assignees
No one assigned
Labels
refactoring Changing directories, modules, structures, etc. without functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bscholtes1A @wolf4ood