Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove publications #85

Merged

Conversation

ronjaquensel
Copy link
Contributor

What this PR changes/adds

Removes the Maven publications from the build files and sets the publish flag to false for modules that should not be published (launchers, system tests).

Why it does that

Once this PR is merged, Maven publications will be added automatically by the Plugin.

Further notes

Renamed modules, so that the module name matches the artifact ID:

  • identity-hub-verifier to identity-hub-credentials-verifier
  • client-cli to identity-hub-cli

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@ronjaquensel ronjaquensel added enhancement New feature or request no-changelog labels Jan 24, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

@ronjaquensel ronjaquensel force-pushed the chore/remove-publications branch from e929129 to bc6d3ed Compare January 26, 2023 13:15
@ronjaquensel ronjaquensel marked this pull request as ready for review January 26, 2023 14:22
@ronjaquensel ronjaquensel requested a review from ndr-brt January 26, 2023 14:22
@ronjaquensel ronjaquensel merged commit 3e6a48f into eclipse-edc:main Jan 26, 2023
@ronjaquensel ronjaquensel deleted the chore/remove-publications branch January 26, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants