refactor: Use EdcHttpClient
#86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../identity-hub-api/src/main/java/org/eclipse/edc/identityhub/api/IdentityHubApiExtension.java
Fixed
Show fixed
Hide fixed
bscholtes1A
force-pushed
the
refactor/78-use-edc-http-client
branch
2 times, most recently
from
6147bd8 to
2db5044
Compare
bscholtes1A
force-pushed
the
refactor/78-use-edc-http-client
branch
from
2db5044 to
07280f0
Compare
ndr-brt
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Use newly introduced
EdcHttpClientinstead of OkHttpClient.Why it does that
EdcHttpClientembeds failsafe.Further notes
We also take opportunity of this PR to separate all self-description related code into a dedicated extension
self-description-apias this is temporary that will be replaced soon by a dedicated extension in the TrustFrameworkAdoption repositoryLinked Issue(s)
Closes #78
Checklist
no-changelog)