Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix compilation #483

Merged
merged 1 commit into from
Nov 6, 2024
Merged

ci: fix compilation #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...ne-aws-s3/src/main/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSinkFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,6 @@ public String supportedType() {
return S3BucketSchema.TYPE;
}

@Override
public boolean canHandle(DataFlowStartMessage request) {
return S3BucketSchema.TYPE.equals(request.getDestinationDataAddress().getType());
}

@Override
public DataSink createSink(DataFlowStartMessage request) {
var validationResult = validateRequest(request);
Expand Down
5 changes: 0 additions & 5 deletions ...-aws-s3/src/main/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSourceFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,6 @@ public String supportedType() {
return S3BucketSchema.TYPE;
}

@Override
public boolean canHandle(DataFlowStartMessage request) {
return S3BucketSchema.TYPE.equals(request.getSourceDataAddress().getType());
}

@Override
public DataSource createSource(DataFlowStartMessage request) {
var validationResult = validateRequest(request);
Expand Down
18 changes: 0 additions & 18 deletions ...ws-s3/src/test/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSinkFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,24 +53,6 @@ class S3DataSinkFactoryTest {
private final S3DataSinkFactory factory = new S3DataSinkFactory(clientProvider, mock(), mock(),
vault, typeManager.getMapper(), 1024, validator);

@Test
void canHandle_returnsTrueWhenExpectedType() {
var dataAddress = DataAddress.Builder.newInstance().type(S3BucketSchema.TYPE).build();

var result = factory.canHandle(createRequest(dataAddress));

assertThat(result).isTrue();
}

@Test
void canHandle_returnsFalseWhenUnexpectedType() {
var dataAddress = DataAddress.Builder.newInstance().type("any").build();

var result = factory.canHandle(createRequest(dataAddress));

assertThat(result).isFalse();
}

@Test
void validate_shouldSucceed_whenValidatorSucceeds() {
when(validator.validateDestination(any())).thenReturn(ValidationResult.success());
Expand Down
18 changes: 0 additions & 18 deletions ...-s3/src/test/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSourceFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,24 +54,6 @@ class S3DataSourceFactoryTest {
private final S3DataSourceFactory factory = new S3DataSourceFactory(clientProvider, mock(),
vault, typeManager.getMapper(), validator);

@Test
void canHandle_returnsTrueWhenExpectedType() {
var dataAddress = DataAddress.Builder.newInstance().type(S3BucketSchema.TYPE).build();

var result = factory.canHandle(createRequest(dataAddress));

assertThat(result).isTrue();
}

@Test
void canHandle_returnsFalseWhenUnexpectedType() {
var dataAddress = DataAddress.Builder.newInstance().type("any").build();

var result = factory.canHandle(createRequest(dataAddress));

assertThat(result).isFalse();
}

@Test
void validate_shouldSucceed_whenValidatorSucceeds() {
when(validator.validateSource(any())).thenReturn(ValidationResult.success());
Expand Down
Loading