-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add new build workflow #61
Conversation
.github/workflows/verify.yaml
Outdated
@@ -31,6 +31,7 @@ jobs: | |||
run: ./gradlew checkstyleMain checkstyleTest | |||
|
|||
Dependency-Check: | |||
if: ${{ inputs.skip-dependency-check != 'true' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for this, dependency-check won't run on scheduled workflows anyway (ref. https://github.com/eclipse-edc/.github/blob/dfb2f1c61348c41d35003b7ab04fc1dd33655077/.github/workflows/dependency-check.yml#L28)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
old comment still not resolved
skip dependency check line removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please re-request the review after you address a change, so I get notified, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR changes/adds
Added nightly.yaml workflow.
Why it does that
Builds and publishes at nights.