Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add new build workflow #61

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Conversation

mehmetihsansevinc
Copy link
Contributor

What this PR changes/adds

Added nightly.yaml workflow.

Why it does that

Builds and publishes at nights.

@mehmetihsansevinc mehmetihsansevinc marked this pull request as ready for review September 11, 2024 13:17
@mspiekermann mspiekermann changed the title release: add new build workflow build: add new build workflow Sep 12, 2024
@@ -31,6 +31,7 @@ jobs:
run: ./gradlew checkstyleMain checkstyleTest

Dependency-Check:
if: ${{ inputs.skip-dependency-check != 'true' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mspiekermann mspiekermann self-assigned this Sep 18, 2024
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old comment still not resolved

@mehmetihsansevinc
Copy link
Contributor Author

old comment still not resolved

skip dependency check line removed

Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re-request the review after you address a change, so I get notified, thanks

.github/workflows/verify.yaml Outdated Show resolved Hide resolved
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndr-brt ndr-brt merged commit f332386 into eclipse-edc:main Sep 19, 2024
12 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants