This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
feat: add document about EDC Best Practices #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
documentation
paullatzelsperger
requested review from
alexandrudanciu,
bscholtes1A,
jimmarino,
juliapampus,
man8pr,
mspiekermann,
ndr-brt,
ronjaquensel,
stefan-ettl and
wolf4ood
paullatzelsperger
force-pushed
the
docs/add_best_practices
branch
from
956d403 to
111ea2f
Compare
mspiekermann
approved these changes
Apr 2, 2024
juliapampus
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Should be linked in the ToC or at least the dev's README, no?
good point, will add references. |
alexandrudanciu
approved these changes
Apr 2, 2024
juliapampus
approved these changes
Apr 2, 2024
Co-authored-by: alexandrudanciu <80531692+alexandrudanciu@users.noreply.github.com>
paullatzelsperger
force-pushed
the
docs/add_best_practices
branch
from
0d4c328 to
80454f4
Compare
jimmarino
approved these changes
Apr 2, 2024
ndr-brt
reviewed
Apr 3, 2024
ndr-brt
approved these changes
Apr 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
adds documentation of some Best Practices
Why it does that
documentation
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.