Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Application UI #260

Merged
merged 2 commits into from
Jun 17, 2023
Merged

Improve Application UI #260

merged 2 commits into from
Jun 17, 2023

Conversation

yashTEF
Copy link
Contributor

@yashTEF yashTEF commented Jun 8, 2023

This PR consists of the following changes:

  1. Improved layout and structuring for the application homepage, with some added visual effects.
  2. Added a progress bar to the web pages for a better ease in on load events.

Screenshot from 2023-06-08 20-08-36
Screenshot from 2023-06-08 20-06-58
Screenshot from 2023-06-08 20-07-08

yashTEF added 2 commits June 8, 2023 19:33
Signed-off-by: yash-bharatiya_psl <yashsoc@gmail.com>
@yashTEF
Copy link
Contributor Author

yashTEF commented Jun 8, 2023

@m-reza-rahman , I have used boilerplate code for the implementation of some of the features.
Curious to know as to how licensing works when it comes to open source software and what can be reproduced and manipulated, this is something a bit unclear to me.

@m-reza-rahman
Copy link
Contributor

Where did the originals come from and did they have a license?

@yashTEF
Copy link
Contributor Author

yashTEF commented Jun 8, 2023

The files src/main/webapp/resources/js/topbar.js, src/main/webapp/resources/js/topbar.min.js
are obtained from: https://github.com/buunguyen/topbar and are covered under the MIT license.

@m-reza-rahman
Copy link
Contributor

OK. MIT is a compatible license for us, so there are no issues to address. I’ll review and merge as soon as possible.

@yashTEF
Copy link
Contributor Author

yashTEF commented Jun 8, 2023

For future reference, what are some things you keep in mind when you encounter library software or dealing with the legal aspects for the same. I have seen MIT, EPL, GPL licenses and their usages but still somewhat unclear to me.

@m-reza-rahman
Copy link
Contributor

We are MIT ourselves, so it is straightforward. Generally any copy-left licenses are fine, but we have to evaluate compatibility on a case-by-case basis. To be honest we try to minimize copy-pasted code and external dependencies as much as possible. Even if licensing is fine, there can be other legal issues.

@m-reza-rahman m-reza-rahman merged commit 69515ae into eclipse-ee4j:master Jun 17, 2023
@m-reza-rahman
Copy link
Contributor

Good work, @yashTEF. I tested and everything looks solid so far.

@m-reza-rahman
Copy link
Contributor

Hi @yashTEF, as part of this work, can you please look into upgrading to PrimeFaces 12 and the "saga" theme? Our current PrimeFaces version and theme are quite old at this point.

@yashTEF
Copy link
Contributor Author

yashTEF commented Jun 18, 2023

Hi @yashTEF, as part of this work, can you please look into upgrading to PrimeFaces 12 and the "saga" theme? Our current PrimeFaces version and theme are quite old at this point.

Indeed, while looking for possible improvements and going through the primefaces documentation I noticed that some components and themes are not available(and also the rendering and styling for the latest version is better) so this should be adopted.

I have updated the dependencies but the styling and structure of JSF pages will need some changes for seamless integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants