Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Server: if possible, use OFFSET and FETCH instead of JDBC methods #309

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

rdicroce
Copy link
Contributor

Same as PR #300, except for master branch.

I'm about to go on vacation, so if there's a problem with this PR, I won't be around to look at it until January.

@lukasj
Copy link
Member

lukasj commented Dec 14, 2018

can you add sign-off to this, please? I can not merge this without it. Thanks!

Signed-off-by: Richard DiCroce <Rich.DiCroce@scientificgames.com>
@rdicroce
Copy link
Contributor Author

Whoops. Should be all set now.

Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit 4ed5f85 into eclipse-ee4j:master Dec 14, 2018
@lukasj
Copy link
Member

lukasj commented Dec 14, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants