Narrowed and fixed dependencies #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmatej
commented
Apr 12, 2024
dmatej
commented
- Using StringUtils from commons-lang3 instead of maven-shared-utils
- commons-lang3 lib was already in transitive deps
- The plexus-archiver is directly referred from FeatureSetDependenciesMojo
- Tested with today both GF master and gf8 branches
- As both Maven and Plexus are moving to the future, they sometimes move classes or remove dependencies. We should respect these changes in the future.
- Using StringUtils from commons-lang3 instead of maven-shared-utils - commons-lang3 lib was already in transitive deps - The plexus-archiver is directly referred from FeatureSetDependenciesMojo - Tested with today both GF master and gf8 branches Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
avpinchuk
approved these changes
Apr 12, 2024
pzygielo
reviewed
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.