Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GF Embedded test suite - part 1 (adds missing Derby JDBC driver to GF Embedded All) #24576

Merged
merged 9 commits into from
Sep 6, 2023

Conversation

OndroMih
Copy link
Contributor

@OndroMih OndroMih commented Sep 5, 2023

Enables GF Embedded tests in the standard build., excluding maven-plugin and web modules for now. These will follow in subsequent PRs.

On top of that:

  • Fix: GlassFish Embedded didn't contain the Derby JDBC driver, now it's added to GF Embedded All (GF Embedded Web is built in a different way and looks like broken now, so I didn't try adding the driver there)
  • Refactored the tests from JUnit 4 to JUnit 5
  • Changed the work dir when running the tests to be inside the target directory, so that files created during the tests are separated from versioned files
  • Introduced the project.directory system property that specifies the Maven project root directory in tests because the work directory is no longer the project root directory
  • added the run-with-uber-jar-web Maven profile to run the tests with GF Embedded Web

All tests pass with the default run-with-uber-jar profile, which uses GF Embedded All.

Not all tests pass with other profiles (Embedded Web and Static Shell). Fixing this is out of scope of this PR. Most of the failing tests fail because of real bugs in those runtimes.

Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Moved test profiles to parent.
Added Derby JDBC driver to GlassFish Embedded
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Profiles must be defined in child POMs, otherwise the default profile 
will remain active all the time.
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
- set work dir inside target directory for creating temporary files
- renamed tests that end in ITest to IUnitTest to run them as UT not IT
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Removed ejb-main standalone test wrapper which isn't used
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
All enabled tests pass in this commit.
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
@dmatej dmatej merged commit a01bc9b into eclipse-ee4j:master Sep 6, 2023
@dmatej dmatej added this to the 7.0.9 milestone Sep 6, 2023
@OndroMih OndroMih deleted the ondromih-gf-embedded-tests branch October 29, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants