-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GF Embedded test suite - part 3 (GF Embedded Maven plugin) #24581
Enable GF Embedded test suite - part 3 (GF Embedded Maven plugin) #24581
Conversation
Until websocket tests, which I only tried to refactor. Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Only tests which fail and there's no simple fix are disabled. Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Conflicts: appserver/tests/embedded/pom.xml Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
The tests failed on some timeouts. Please, rerun the build, @dmatej , @avpinchuk , @arjantijms . |
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
I forgot to add the GF Embedded test suite to the default test suites. I added it with the latest commit in this PR. |
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
@OndroMih, local build failed too. |
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
It was failing because the "fastest" profile sets "maven.skip.tests=true" to disable all tests. I removed the tests from the fastest profile. |
Again some tests failed on timeouts, please restart the build. |
One moment, please ;) Three local builds, one by one, passed. |
appserver/tests/embedded/maven-plugin/applicationDispatcher/pom.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mvn clean install -pl :maven-plugin -amd
Passed, just some warmings:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for GlassFish Embedded Maven Plugin Tests 7.0.9-SNAPSHOT:
[INFO]
[INFO] GlassFish Embedded Maven Plugin Tests .............. SUCCESS [ 1.824 s]
[INFO] Application Dispatcher Test (maven-plugin/applicationDispatcher) SUCCESS [ 6.871 s]
[INFO] Directory Listing Test (maven-plugin/dirListing) ... SUCCESS [ 2.156 s]
[INFO] Filter URI Mapping Test (maven-plugin/filterURIMapping) SUCCESS [ 2.048 s]
[INFO] Get Request URI Test (maven-plugin/getRequestURI) .. SUCCESS [ 0.529 s]
[INFO] Index Page Test (maven-plugin/index) ............... SUCCESS [ 1.633 s]
[INFO] JMX Undeployment Event Test (maven-plugin/jmsUndeploymentTest) SUCCESS [ 1.396 s]
[INFO] Query String Test (maven-plugin/queryString) ....... SUCCESS [ 1.421 s]
[INFO] Session Lifecyle Test (maven-plugin/sessionDestroyed) SUCCESS [ 1.533 s]
[INFO] Standalone WAR Test (maven-plugin/standalonewar) ... SUCCESS [ 1.594 s]
[INFO] Test https and other plugin configurations (maven-plugin/secureWebApp) SUCCESS [ 1.686 s]
[INFO] Test web app containing JSPs/JSTLs (maven-plugin/jsptest) SUCCESS [ 2.248 s]
[INFO] Multiple application deployment test (maven-plugin/multipleApps) SUCCESS [ 2.518 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 29.371 s
[INFO] Finished at: 2023-09-11T12:19:09+02:00
[INFO] ------------------------------------------------------------------------
[WARNING]
[WARNING] Plugin validation issues were detected in 3 plugin(s)
[WARNING]
[WARNING] * org.apache.maven.plugins:maven-enforcer-plugin:3.1.0
[WARNING] * org.glassfish.embedded:maven-embedded-glassfish-plugin:5.1
[WARNING] * org.apache.maven.plugins:maven-war-plugin:3.3.2
[WARNING]
[WARNING] For more or less details, use 'maven.plugin.validation' property with one of the values (case insensitive): [BRIEF, DEFAULT, VERBOSE]
[WARNING]
Btw those start times are very good:
INFO: GlassFish (commit: null) startup time: Embedded (36 ms), startup services (22 ms), total (58 ms)
appserver/tests/embedded/maven-plugin/standalonewar/src/main/java/test/ServletTest3.java
Show resolved
Hide resolved
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
This parameter was wrongly used. It's supposed to be used in the maven plugin itself to configure the prefix. But this cannot be overriden in a maven project that uses the plugin. Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
@dmatej, I ran
it's not relared to changes in this PR. It's related to problems in the plugins:
I didn't see anything for the war plugin. |
Enables another part of GF Embedded tests for the maven plugin.
From my side, this is the last part of PRs that enable GF Embedded tests, I'm not going to work on this any longer There are still some disabled tests which might be worth enabling and fixing in the future.