Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JDK 11 ALPN #2103

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Add support for JDK 11 ALPN #2103

merged 2 commits into from
Nov 20, 2020

Conversation

MattGill98
Copy link
Contributor

Created a new phase in the handshake listener to allow registration of the custom ALPN logic. This allows the HTTP/2 filter to work correctly.

Depends on eclipse-ee4j/grizzly-npn#19, and also assumes that there is a new release of the grizzly-npn API (I've assumed 2.0).

Tested on OpenJDK 11.0.1.

@MattGill98 MattGill98 requested a review from arjantijms July 23, 2020 15:18
@MattGill98 MattGill98 self-assigned this Jul 23, 2020
@MattGill98 MattGill98 changed the title FISH-31 Add support for JDK 11 ALPN Add support for JDK 11 ALPN Jul 23, 2020
@MattGill98 MattGill98 requested a review from anajosep July 24, 2020 12:15
Copy link
Member

@m0mus m0mus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Create new phase in the handshake listener to allow registration of the
custom ALPN logic. This allows the HTTP/2 filter to work correctly.

Signed-off-by: Matthew Gill <matthew.gill@live.co.uk>
@MattGill98
Copy link
Contributor Author

I moved the HandshakeListener class back to fix TCK issues, now just waiting on a grizzly-npn 2.0 release

@arjantijms arjantijms merged commit 9629829 into eclipse-ee4j:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants