Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Converted to plain AsciiDoc #191

Merged
merged 15 commits into from
Jun 30, 2020
Merged

Conversation

ggam
Copy link
Member

@ggam ggam commented Apr 24, 2020

This PR converts the whole tutorial to plain AsciiDoc without JBake. The result can be seen at http://www.ggam.eu/jakartaee-tutorial/

I haven't made any content changes besides removing duplicated titles that weren't needed anymore. To the best of my knowledge, all links and images are still working and this PR is in a mergeable state.

This makes the tutorial easier to maintain and provides a more modern look.

Things I've made:

  • Reorganized files in folders. Once the content is updated for Jakarta EE 9, old stuff can be deleted or moved to a "Legacy stuff" category.
  • Replaced setext headings with the recommended atx (https://asciidoctor.org/docs/asciidoc-recommended-practices/#section-titles)
  • Removed handcrafted tables of contents.
  • Enabled syntax highlighting.
  • Updating Maven dependencies and cleaning up pom. Now compiles on Java 14.
  • Fixed AsciiDoctor warnings and errors. This affected some nested lists.

Closes:

And makes it straightforward to solve #129.

ggam added 9 commits April 24, 2020 21:39
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Fix images

Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
@ggam ggam mentioned this pull request Apr 26, 2020
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
@ggam
Copy link
Member Author

ggam commented Jun 26, 2020

I know everyone's busy with Jakarta EE 9 work, but could someone please take a look and approve this? I'd like to see this landing to master before I continue working on it.

Copy link
Member

@ivargrimstad ivargrimstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no way the bandwidth to review 1005 files, but I trust you when you say that no content has changed and the reorganizing looks excellent to me. Thanks!

@ggam
Copy link
Member Author

ggam commented Jun 26, 2020

Thanks Ivar! One more approver and we could merge this please?

@ggam
Copy link
Member Author

ggam commented Jun 28, 2020

@keilw since you are around, would you please have a look at this?

@keilw
Copy link
Member

keilw commented Jun 28, 2020

This is really massive, but if it works for you @ggam this looks like the only PR that has no IP problem, so I have a look and might merge it this evening.

@ggam
Copy link
Member Author

ggam commented Jun 28, 2020

Thanks @keilw. I'm aware this is a very big PR and I understand the tutorial is noone's priority right now, but this is needed before moving forward.. #193 (draft) only adds some changes on top of this one.

@ivargrimstad ivargrimstad merged commit 46a66ae into eclipse-ee4j:master Jun 30, 2020
@ggam
Copy link
Member Author

ggam commented Jun 30, 2020 via email

@keilw
Copy link
Member

keilw commented Jun 30, 2020

I saw @ivargrimstad already merged it, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants