-
Notifications
You must be signed in to change notification settings - Fork 70
Conversation
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Fix images Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
I know everyone's busy with Jakarta EE 9 work, but could someone please take a look and approve this? I'd like to see this landing to master before I continue working on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no way the bandwidth to review 1005 files, but I trust you when you say that no content has changed and the reorganizing looks excellent to me. Thanks!
Thanks Ivar! One more approver and we could merge this please? |
@keilw since you are around, would you please have a look at this? |
This is really massive, but if it works for you @ggam this looks like the only PR that has no IP problem, so I have a look and might merge it this evening. |
Thanks!
El mar., 30 jun. 2020 9:57, Ivar Grimstad <notifications@github.com>
escribió:
… Merged #191 <#191>
into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#191 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQC44AXCE4S57AXLC53NKTRZGLFLANCNFSM4MQMPHDQ>
.
|
I saw @ivargrimstad already merged it, thanks. |
This PR converts the whole tutorial to plain AsciiDoc without JBake. The result can be seen at http://www.ggam.eu/jakartaee-tutorial/
I haven't made any content changes besides removing duplicated titles that weren't needed anymore. To the best of my knowledge, all links and images are still working and this PR is in a mergeable state.
This makes the tutorial easier to maintain and provides a more modern look.
Things I've made:
Closes:
And makes it straightforward to solve #129.