Cleanup old JDK collection compatibility classes #3979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mszabo-wikia <mszabo@wikia-inc.com>
Closed
jansupol
approved these changes
Feb 18, 2019
senivam
approved these changes
Feb 19, 2019
This was referenced Jun 26, 2021
This was referenced Aug 5, 2021
This was referenced Sep 5, 2021
This was referenced Oct 4, 2021
This was referenced Oct 18, 2021
This was referenced Oct 21, 2021
Merged
Merged
This was referenced Oct 21, 2021
Closed
Closed
1 task
This was referenced Mar 7, 2022
This was referenced Mar 15, 2022
This was referenced Apr 17, 2022
This was referenced May 3, 2022
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the following package-private compatibility classes that serve no purpose in Java 8 and above:
org.glassfish.jersey.internal.util.collection.ConcurrentHashMapV8org.glassfish.jersey.internal.util.collection.LinkedTransferQueueorg.glassfish.jersey.internal.util.collection.ThreadLocalRandomThe public factory methods in
org.glassfish.jersey.internal.util.collection.DataStructuresthat originally instantiated these classes were modified to always return the JDK equivalents of these classes. Additionally, the methods were marked as@Deprecatedand method documentations were updated to clarify that callers can now simply instantiate the required JDK collection class without having to use these factories. Use of these factories inside Jersey itself was removed.Finally, the
org.glassfish.jersey.internal.util.JdkVersionclass was updated to allow it to properly handle new version strings used for Java 9 and above, and unit tests were added to cover this logic.This is a re-implementation of #3976
Signed-off-by: mszabo-wikia mszabo@wikia-inc.com