Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SpringComponentProvider to look for beans in current and parent application contexts #4080

Merged
merged 1 commit into from
May 22, 2019
Merged

Change SpringComponentProvider to look for beans in current and parent application contexts #4080

merged 1 commit into from
May 22, 2019

Conversation

radarsh
Copy link
Contributor

@radarsh radarsh commented Mar 20, 2019

Signed-off-by: Adarsh Ramamurthy adarsh.ramamurthy@gmail.com

@radarsh
Change SpringComponentProvider to look for beans in current and paren…
e23e96e 
…t contexts

Signed-off-by: Adarsh Ramamurthy <adarsh.ramamurthy@gmail.com>
@radarsh radarsh mentioned this pull request Mar 20, 2019
Open
@radarsh
Copy link
Contributor Author

radarsh commented Mar 20, 2019

I still don't understand how LocalizationMessages is resolved as in my IDE, it results in a compilation error. If there is a set up step that needs to be followed, please include that in the contribution guide.

@jansupol
Copy link
Contributor

Relates to #4062

@jansupol jansupol mentioned this pull request Mar 26, 2019
Merged
@ankurpathak
Copy link
Contributor

ankurpathak commented Mar 27, 2019 •
edited
Loading

I still don't understand how LocalizationMessages is resolved as in my IDE, it results in a compilation error. If there is a set up step that needs to be followed, please include that in the contribution guide.

@radarsh Even I was getting the same error. Its auto generated source. You run mvn clean package inside spring4 artifact and you will find that file inside build directory target. You can repeat same for spring5 artifact also.

@ankurpathak ankurpathak mentioned this pull request Mar 27, 2019
Closed
@jansupol jansupol mentioned this pull request May 21, 2019
Open
jansupol
jansupol approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@jansupol jansupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed in Jersey 1 a long time ago.

senivam
senivam approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@senivam senivam merged commit a41590e into eclipse-ee4j:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senivam senivam senivam approved these changes

@jansupol jansupol jansupol approved these changes

Assignees
No one assigned
Labels
spring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radarsh @jansupol @ankurpathak @senivam