Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MP rest client 1.2.1 implementation #4086

Merged
merged 3 commits into from
Jun 11, 2019
Merged

MP rest client 1.2.1 implementation #4086

merged 3 commits into from
Jun 11, 2019

Conversation

Verdent
Copy link
Member

@Verdent Verdent commented Mar 26, 2019

MP rest client implementation

@jansupol jansupol mentioned this pull request Mar 27, 2019
Closed
@smillidge
Copy link

This PR depends on Helidon that should be removed I think only MicroProfile dependencies should be added.

@Verdent
Copy link
Member Author

Verdent commented Mar 28, 2019 •
edited
Loading

Hi @smillidge would it be acceptable from your point of view to move all helidon dependecies to the test scope?

@Verdent
Copy link
Member Author

Verdent commented Apr 4, 2019

Helidon removed from this implementation.

pdudits
pdudits suggested changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@pdudits pdudits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried integrating your client into Payara and found few things to be improved in order to work also in our environment:

ext/mp-rest-client/pom.xml Outdated Show resolved Hide resolved
ext/mp-rest-client/pom.xml Outdated Show resolved Hide resolved
ext/mp-rest-client/pom.xml Outdated Show resolved Hide resolved
ext/mp-rest-client/src/main/java/org/glassfish/jersey/restclient/InterfaceUtil.java Outdated Show resolved Hide resolved
ext/mp-rest-client/src/main/java/org/glassfish/jersey/restclient/RestClientBuilderImpl.java Outdated Show resolved Hide resolved
@pdudits pdudits mentioned this pull request Apr 25, 2019
Merged
@jansupol
Copy link
Contributor

Please add this module to the ext/microprofile/restclient folder.
Please add this to org.glassfish.jersey.microprofile.restclient package.
It seems we are getting more microprofile specific code.

@jansupol jansupol mentioned this pull request May 9, 2019
Closed
This was referenced May 15, 2019
Closed
Merged
@jansupol
Copy link
Contributor

CQ #19756 for SmallRye seems to have licensing issues, as it incorrectly refers to LGPL. Possibly, we need to use some other MP config implementation till SmallRye is released with the fixed license to be able to put this to 2.29

@senivam senivam mentioned this pull request May 29, 2019
Merged
@renovate renovate bot mentioned this pull request Oct 18, 2021
Open
1 task
This was referenced Oct 21, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@renovate renovate bot mentioned this pull request Jan 10, 2022
Open
1 task
This was referenced Mar 7, 2022
Closed
Closed
This was referenced Mar 15, 2022
Merged
Merged
This was referenced Apr 17, 2022
Closed
Closed
This was referenced May 3, 2022
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request May 12, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Sep 23, 2022
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 5, 2022
Open
@renovate renovate bot mentioned this pull request Feb 11, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senivam senivam senivam left review comments

@pdudits pdudits pdudits requested changes

@jansupol jansupol jansupol approved these changes

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees
No one assigned
Labels
2.29
Projects
None yet
Milestone
2.29
Development

Successfully merging this pull request may close these issues.
6 participants
@Verdent @smillidge @jansupol @pdudits @tomas-langer @senivam