Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix priority ordering #4103

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Fix priority ordering #4103

merged 1 commit into from
Apr 23, 2019

Conversation

jansupol
Copy link
Contributor

Signed-off-by: Jan Supol jan.supol@oracle.com

@jansupol
Fix priority ordering
3a633fc 
Signed-off-by: Jan Supol <jan.supol@oracle.com>
@jansupol
Copy link
Contributor Author

Fixes #4099.

@jansupol jansupol mentioned this pull request Apr 17, 2019
Closed
chkal
chkal approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@chkal chkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jansupol! Thanks a lot! That's awesome! I can confirm that this patch fixes the issue.

Does it make sense to merge #4101 first?

@chkal chkal mentioned this pull request Apr 18, 2019
Merged
senivam
senivam approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@senivam
Copy link
Contributor

senivam commented Apr 18, 2019 •
edited
Loading

@chkal I suppose, it should be vice versa. As soon as #4101 is ignored for now and will be valid only after this PR is merged. So this goes first and then #4101 without @ Ignore

@chkal
Copy link
Contributor

chkal commented Apr 18, 2019

Ok, sure! I'll update #4101 and remove the @Ignore as soon as this PR is merged! Thanks a lot for your help.

tomas-langer
tomas-langer approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jansupol jansupol merged commit a62d1ff into eclipse-ee4j:master Apr 23, 2019
@jansupol
Copy link
Contributor Author

@chkal Please remove @Ignore. Thank you for the very nice test case.

@chkal
Copy link
Contributor

chkal commented Apr 24, 2019

I just updated #4101 as requested. I hope the test case was useful for reproducing the issue.

@jansupol jansupol deleted the priorityfix branch May 30, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senivam senivam senivam approved these changes

@tomas-langer tomas-langer tomas-langer approved these changes

@chkal chkal chkal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jansupol @senivam @chkal @tomas-langer