Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3997 : Make SupplierFactoryBridge thread-safe. #4178

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Fixes #3997 : Make SupplierFactoryBridge thread-safe. #4178

merged 1 commit into from
Aug 23, 2019

Conversation

hypnoce
Copy link
Contributor

@hypnoce hypnoce commented Jun 25, 2019

Based on #4000

@hypnoce
Copy link
Contributor Author

hypnoce commented Jun 25, 2019

Some jobs have failed on travis. Seems that they are not related to the changes. Can you confirm ?

@jansupol
Copy link
Contributor

This seems to be the most recent bug for this issue. My feeling from the bug is Travis is going to remove the Oracle JDK support. The solution can be to switch to OpenJDK11 if the issue is not resolved next week.

@jansupol
Copy link
Contributor

The Travis issues are being solved in #4180

@hypnoce
Copy link
Contributor Author

hypnoce commented Jun 28, 2019

I will wait for your PR to be merged, and then rebase mine.

@hypnoce
Copy link
Contributor Author

hypnoce commented Jul 8, 2019 •
edited
Loading

The build has passed. I there anything to change in this PR ?

@hypnoce
Copy link
Contributor Author

hypnoce commented Jul 18, 2019

@jansupol is there anything preventing this PR to be merged ?

@jansupol
Copy link
Contributor

@hypnoce Can you please update copyright year?

@hypnoce
Fixes eclipse-ee4j#3997 : Make SupplierFactoryBridge thread-safe.
6d35782 
Signed-off-by: Francois JACQUES <fjacques@murex.com>
@hypnoce
Copy link
Contributor Author

hypnoce commented Aug 12, 2019

@jansupol done !

tomas-langer
tomas-langer approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jansupol jansupol mentioned this pull request Aug 12, 2019
Closed
@jansupol jansupol added this to the 2.29.1 milestone Aug 12, 2019
@hypnoce
Copy link
Contributor Author

hypnoce commented Aug 12, 2019

Apparently there was an OOM on the CI

@jansupol jansupol merged commit 66f5cfa into eclipse-ee4j:master Aug 23, 2019
This was referenced Jun 26, 2021
Merged
Open
Open
Merged
Open
This was referenced Aug 5, 2021
Closed
Closed
This was referenced Sep 5, 2021
Merged
Merged
Merged
This was referenced Oct 4, 2021
Merged
Merged
This was referenced Oct 21, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@renovate renovate bot mentioned this pull request Jan 10, 2022
Open
1 task
This was referenced Mar 7, 2022
Closed
Closed
This was referenced Mar 15, 2022
Merged
Merged
This was referenced Apr 17, 2022
Closed
Closed
This was referenced May 3, 2022
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request May 12, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Sep 23, 2022
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 5, 2022
Open
@renovate renovate bot mentioned this pull request Feb 11, 2023
Merged
1 task
@renovate renovate bot mentioned this pull request May 11, 2023
Open
1 task
This was referenced May 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansupol jansupol jansupol approved these changes

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.29.1
Development

Successfully merging this pull request may close these issues.
3 participants
@hypnoce @jansupol @tomas-langer