Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Various bugs in Helloworld CDI SE Example #4206

Merged
merged 3 commits into from
Jul 26, 2019
Merged

Fixed: Various bugs in Helloworld CDI SE Example #4206

merged 3 commits into from
Jul 26, 2019

Conversation

mkarg
Copy link
Member

@mkarg mkarg commented Jul 22, 2019

This PR fixes various bugs of the Helloworld CDI SE example.

  1. README.MD - Sample link misses mandatory parameter
  2. pom.xml - Surplus prefix for main class
  3. App.java - Surplus base path for root url

@mkarg
Copy link
Member Author

mkarg commented Jul 22, 2019

@eclipsewebmaster @eclipse-ece-validation The Eclipse FDN / ECA validation fails to connect its internal database. Can you please fix this? Thanks! :-)

@senivam
Copy link
Contributor

senivam commented Jul 22, 2019

it's because commit's header is validated vs author's email (karg@quipsy.de) and that email does not have ECA signed


commit 685f381415329fad95504b9f20858a95d02b3d15
Author:     Markus KARG <karg@quipsy.de>
AuthorDate: Mon Jul 22 08:47:03 2019 +0200
Commit:     Markus KARG <markus@headcrashing.eu>
CommitDate: Mon Jul 22 12:37:29 2019 +0200

@mkarg
Copy link
Member Author

mkarg commented Jul 22, 2019

@senivam Thank you for inspecting this, I will fix the author line ASAP. Anyways, this does not explain why the ECA check fails to connect to Eclipse Foundation's MariaDB...

@mkarg @quipsy-karg
Fixed: Various bugs in Helloworld CDI SE Example
56d67c5 
(1) README.MD - Sample link misses mandatory parameter
(2) pom.xml - Surplus prefix for main class
(3) App.java - Surplus base path for root url

Signed-off-by: Markus KARG <markus@headcrashing.eu>
@mkarg
Copy link
Member Author

mkarg commented Jul 22, 2019

@senivam Fixed the ECA check, but Travis failed with connect problems under your user while the same build works with my user. Can you please press "Retry" in Travis CI for the failing build so this PR passes the final check? Thanks! :-)

@mkarg
Copy link
Member Author

mkarg commented Jul 22, 2019

@senivam Thanks! :-)

@mkarg
Copy link
Member Author

mkarg commented Jul 22, 2019

All checks passed. Requesting merge. :-)

@senivam
Copy link
Contributor

senivam commented Jul 22, 2019

@mkarg you are welcome :) it's obvious that you would like to have it merged, or why to submit PR at all? :) And for sure after review there is a possibility that it will be merged though...

@mkarg
Copy link
Member Author

mkarg commented Jul 22, 2019

@senivam Wasn't intended to stress you; just wanted to inform that the troubles we had with this PR are finally passed, nothing more. :-)

@mkarg
Copyright (C) 2019
c2f3392 
Signed-off-by: Markus KARG <markus@headcrashing.eu>
@mkarg mkarg force-pushed the helloworld-fix branch 2 times, most recently from 63a310d to c87b849 Compare July 24, 2019 10:50
@mkarg
Fixed: Server outputs wrong root path for helloworld
b15eb34 
Signed-off-by: Markus KARG <markus@headcrashing.eu>
@mkarg
Copy link
Member Author

mkarg commented Jul 24, 2019

@senivam Changed as requested. Travis succeeded in my fork, but failed in origin. I think it will pass if you restart the two failing jobs. It seems Travis is rathe runstable these days.

senivam
senivam approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkarg
Copy link
Member Author

mkarg commented Jul 26, 2019

@jansupol @arjantijms Requesting 2nd review. 🙏

@mkarg
Copy link
Member Author

mkarg commented Jul 26, 2019

@arjantijms Thanks a lot! 🎉

@senivam senivam merged commit 35e581f into eclipse-ee4j:master Jul 26, 2019
@mkarg mkarg deleted the helloworld-fix branch July 26, 2019 15:16
@jansupol jansupol added this to the 2.29.1 milestone Aug 12, 2019
This was referenced Jun 26, 2021
Merged
Open
Open
Merged
This was referenced Oct 21, 2021
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@renovate renovate bot mentioned this pull request Jan 10, 2022
Open
1 task
This was referenced Mar 7, 2022
Closed
Closed
This was referenced Mar 15, 2022
Merged
Merged
This was referenced Apr 17, 2022
Closed
Closed
This was referenced May 3, 2022
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request May 12, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Sep 23, 2022
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 5, 2022
Open
@renovate renovate bot mentioned this pull request Feb 11, 2023
Merged
1 task
@renovate renovate bot mentioned this pull request May 11, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Jul 6, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Aug 30, 2023
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 4, 2023
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senivam senivam senivam approved these changes

@arjantijms arjantijms arjantijms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.29.1
Development

Successfully merging this pull request may close these issues.
4 participants
@mkarg @senivam @arjantijms @jansupol