Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use locale insensitive case changes to ensure user code doesn't break… #4268

Merged
merged 4 commits into from
Oct 10, 2019
Merged

Use locale insensitive case changes to ensure user code doesn't break… #4268

merged 4 commits into from
Oct 10, 2019

Conversation

mjameson-se
Copy link
Contributor

… in other locales (i.e. Turkey)

@mjameson-se
Use locale insensitive case changes to ensure user code doesn't break…
b1a0659 
… in other locales (i.e. Turkey)

Signed-off-by: Michael Jameson <mjameson.se@gmail.com>
@mjameson-se
Fix checkstyle violation - line length
5ff0430 
Signed-off-by: Michael Jameson <mjameson.se@gmail.com>
@mjameson-se
Fix tabs vs spaces
7c346df 
Signed-off-by: Michael Jameson <mjameson.se@gmail.com>
@mjameson-se mjameson-se marked this pull request as ready for review September 20, 2019 21:36
jansupol
jansupol requested changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@jansupol jansupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but please update the copyright year to 2019

@mjameson-se
Bump copyrights to 2019
3a007a0 
Signed-off-by: Michael Jameson <mjameson.se@gmail.com>
@mjameson-se
Copy link
Contributor Author

This looks good, but please update the copyright year to 2019

I'm not certain what you mean but I took a guess based on other files' copyright headers

@jansupol jansupol self-requested a review October 3, 2019 16:30
@mjameson-se mjameson-se removed their assignment Oct 7, 2019
@senivam senivam added this to the 2.29.2 milestone Oct 10, 2019
@senivam senivam merged commit 05a64a2 into eclipse-ee4j:master Oct 10, 2019
@jansupol jansupol modified the milestones: 2.29.2, 2.30 Nov 5, 2019
This was referenced Jun 26, 2021
Merged
Open
Open
Merged
Open
This was referenced Aug 5, 2021
Closed
Closed
This was referenced Aug 30, 2021
Closed
Merged
Merged
Merged
This was referenced Oct 21, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@renovate renovate bot mentioned this pull request Jan 10, 2022
Open
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Feb 5, 2022
Closed
1 task
This was referenced Mar 7, 2022
Closed
Closed
This was referenced Mar 15, 2022
Merged
Merged
This was referenced Apr 17, 2022
Closed
Closed
This was referenced May 3, 2022
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request May 12, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Sep 23, 2022
Merged
1 task
This was referenced Oct 19, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 5, 2022
Open
@renovate renovate bot mentioned this pull request Feb 11, 2023
Merged
1 task
@renovate renovate bot mentioned this pull request May 11, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Jul 6, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Aug 30, 2023
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 4, 2023
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 11, 2024
Open
This was referenced Apr 13, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senivam senivam senivam approved these changes

@jansupol jansupol jansupol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.30
Development

Successfully merging this pull request may close these issues.
3 participants
@mjameson-se @jansupol @senivam