Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not handle already handled requests on Jetty #4271

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Do not handle already handled requests on Jetty #4271

merged 1 commit into from
Oct 2, 2019

Conversation

dbazile
Copy link
Contributor

@dbazile dbazile commented Sep 23, 2019

Prevents EOFException if JettyHttpContainer is in a HandlerCollection and is downstream of another handler that successfully handled a request.

Resubmission of #4269 since adding "Signed-Off" to commit message blew up the commit history.

This can occur if the JettyHttpContainer in a HandlerCollection and is
downstream of another handler that successfully handled a request.

Closes #4262

Signed-off-by: David Bazile <dbazile@users.noreply.github.com>
@jansupol
Copy link
Contributor

Uhm... you do realize that you have signed the ECA with an associated email address that is different to your dbazile[at]users.noreply.github.com, right?

@dbazile
Copy link
Contributor Author

dbazile commented Sep 23, 2019

Ha, I do. I can send you personally an email from my actual email to confirm I am who I say I am but for anti-spam and privacy reasons, I don't use my personal address for public GitHub commits.

I've also checked the commit history for other contributers and a few of them are also using GitHub's "noreply" address.

@dbazile
Copy link
Contributor Author

dbazile commented Sep 23, 2019

I also found this ECA bug report relating to handling of GitHub's "noreply" alias:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=496885#c20

It seems like it's an understood issue and work is being done to address it. Is there any other way to confirm ECA acceptance?

@jansupol
Copy link
Contributor

I do not know. Let's see whether they fix it soon.

@jansupol
Copy link
Contributor

jansupol commented Oct 1, 2019

They have fixed the issue

@jansupol jansupol changed the title Prevent EOFException if request already handled Do not handle already handled requests on Jetty Oct 2, 2019
@senivam senivam merged commit 11004cf into eclipse-ee4j:master Oct 2, 2019
@senivam senivam added this to the 2.29.2 milestone Oct 2, 2019
@jansupol jansupol modified the milestones: 2.29.2, 2.30 Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants