-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not handle already handled requests on Jetty #4271
Conversation
This can occur if the JettyHttpContainer in a HandlerCollection and is downstream of another handler that successfully handled a request. Closes #4262 Signed-off-by: David Bazile <dbazile@users.noreply.github.com>
Uhm... you do realize that you have signed the ECA with an associated email address that is different to your dbazile[at]users.noreply.github.com, right? |
Ha, I do. I can send you personally an email from my actual email to confirm I am who I say I am but for anti-spam and privacy reasons, I don't use my personal address for public GitHub commits. I've also checked the commit history for other contributers and a few of them are also using GitHub's "noreply" address. |
I also found this ECA bug report relating to handling of GitHub's "noreply" alias: It seems like it's an understood issue and work is being done to address it. Is there any other way to confirm ECA acceptance? |
I do not know. Let's see whether they fix it soon. |
They have fixed the issue |
Prevents EOFException if JettyHttpContainer is in a HandlerCollection and is downstream of another handler that successfully handled a request.
Resubmission of #4269 since adding "Signed-Off" to commit message blew up the commit history.