Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvement in Resource.Builder#mergeResources #4300

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Performance improvement in Resource.Builder#mergeResources #4300

merged 2 commits into from
Nov 20, 2019

Conversation

jansupol
Copy link
Contributor

Signed-off-by: Jan Supol jan.supol@oracle.com

@jansupol
Copy link
Contributor Author

An alternative to #4297

senivam
senivam requested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's perfect alternative, however I would advise to take it from the actual master. Rebase master onto your branch. Since mine is already merged so I'm not sure if it would revert LinkedList back onto ArrayList.

@jansupol
Performance improvement in Resource.Builder#mergeResources
6fae3b4 
Signed-off-by: Jan Supol <jan.supol@oracle.com>
@jansupol
Copy link
Contributor Author

Rebased on top of the master

@senivam
Copy link
Contributor

senivam commented Oct 28, 2019

this line:
this.childResources = new ArrayList<>();
shall be reverted to LinkedList if I understand correctly...

@jansupol
Revert LinkedList->ArrayList to keep fast Iterator.remove
2deef24 
Signed-off-by: Jan Supol <jan.supol@oracle.com>
@jansupol jansupol mentioned this pull request Nov 1, 2019
Closed
@jansupol jansupol merged commit b86c80e into eclipse-ee4j:master Nov 20, 2019
@jansupol jansupol deleted the resource_perf branch November 20, 2019 09:49
@jansupol jansupol added this to the 2.30 milestone Nov 20, 2019
@jansupol jansupol self-assigned this Nov 23, 2019
This was referenced Jun 26, 2021
Merged
Open
Open
Merged
Open
This was referenced Aug 5, 2021
Closed
Closed
This was referenced Aug 30, 2021
Closed
Merged
Merged
Merged
@renovate renovate bot mentioned this pull request Sep 6, 2021
Merged
1 task
This was referenced Oct 4, 2021
Merged
Merged
@renovate renovate bot mentioned this pull request Oct 18, 2021
Open
1 task
This was referenced Oct 21, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@renovate renovate bot mentioned this pull request Jan 10, 2022
Open
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Feb 5, 2022
Closed
1 task
This was referenced Mar 7, 2022
Closed
Closed
This was referenced Mar 15, 2022
Merged
Merged
This was referenced Apr 17, 2022
Closed
Closed
This was referenced May 3, 2022
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request May 12, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Sep 23, 2022
Merged
1 task
This was referenced Oct 19, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 5, 2022
Open
@renovate renovate bot mentioned this pull request Feb 11, 2023
Merged
1 task
@renovate renovate bot mentioned this pull request May 11, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Jul 6, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Aug 30, 2023
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 4, 2023
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 11, 2024
Open
@renovate renovate bot mentioned this pull request Apr 19, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senivam senivam senivam approved these changes

@Verdent Verdent Verdent approved these changes

Assignees

@jansupol jansupol

Labels
performance
Projects
None yet
Milestone
2.30
Development

Successfully merging this pull request may close these issues.
3 participants
@jansupol @senivam @Verdent