Query parameters were not included in netty URI #4393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
senivam
reviewed
Feb 13, 2020
| @@ -282,6 +283,14 @@ public void run() { | |||
| return settableFuture; | |||
| } | |||
|
|
|||
| private String buildPathWithQueryParameters(URI requestUri) { | |||
| if (requestUri.getRawQuery() != null) { | |||
| return new StringBuilder(requestUri.getRawPath()).append("?").append(requestUri.getRawQuery()).toString(); | |||
There was a problem hiding this comment.
Why not to use return String.format("%s?%s", requestUri.getRawPath(), requestUri.getRawQuery());?
And do not forget about copyright year please...
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
senivam
approved these changes
Feb 13, 2020
jansupol
approved these changes
Feb 17, 2020
This was referenced Feb 17, 2020
jansupol
pushed a commit
to jansupol/jersey
that referenced
this pull request
Mar 23, 2020
* Query parameters were not included in netty URI Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com> (cherry picked from commit 706c01c) Signed-off-by: Jan Supol <jan.supol@oracle.com>
senivam
pushed a commit
to senivam/jersey
that referenced
this pull request
Apr 22, 2020
* Query parameters were not included in netty URI Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com> (cherry picked from commit 706c01c) Signed-off-by: Jan Supol <jan.supol@oracle.com>
senivam
pushed a commit
to senivam/jersey
that referenced
this pull request
Apr 27, 2020
* Query parameters were not included in netty URI Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
This was referenced Jun 26, 2021
This was referenced Aug 5, 2021
This was referenced Aug 30, 2021
1 task
This was referenced Oct 4, 2021
This was referenced Oct 18, 2021
This was referenced Oct 21, 2021
Closed
Closed
1 task
1 task
This was referenced Mar 7, 2022
This was referenced Mar 15, 2022
This was referenced Apr 17, 2022
This was referenced May 3, 2022
1 task
1 task
This was referenced Oct 19, 2022
1 task
1 task
1 task
1 task
This was referenced Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the issue:
#4369
I didn't find a better solution for this because the Netty HttpRequest doesn't have a method to add query parameters.