Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some build warnings and a multithread warning, when building with… #4441

Merged
merged 1 commit into from
May 11, 2020

Conversation

thomasmey
Copy link

… -T 1C

@thomasmey thomasmey force-pushed the bugfix/pom-build-warnings branch from 627b68f to 58dbf2a Compare April 19, 2020 08:17
@jansupol
Copy link
Contributor

Thank you for contribution. It looks good. Except, can you please update the copyright year in the modified files?

@thomasmey
Copy link
Author

hi, yes can do, but one question, what does it mean that there are two years, e.g.:
"Copyright (c) 2015, 2018..."

In what should I change it?
a.) Copyright (c) 2020
b.) Copyright (c) 2015, 2020
c.) Copyright (c) 2015, 2018, 2020

I think this copyright notice is only relevant for US law only?!

Also this seems to indicate that the notice is even not necessary any more at all:
https://en.wikipedia.org/wiki/Copyright_symbol
but OTOH IANAL!

@jansupol
Copy link
Contributor

We use two years, the year of creation and the year of the last change. So option B, please.

The Eclipse Foundation says:

{DATE} is either a year or a range of years with the first and last years of the range separated by a comma. So for example: "2004" or "2000, 2004". The first year is when the contents of the file were first created and the last year is the last year is when the contents were last modified.

… -T 1C

Signed-off-by: Thomas Meyer <thomas.mey@web.de>
@thomasmey thomasmey force-pushed the bugfix/pom-build-warnings branch from 58dbf2a to e36ceae Compare April 25, 2020 19:43
@jansupol jansupol merged commit 5774994 into eclipse-ee4j:master May 11, 2020
@jansupol jansupol added this to the 2.31 milestone May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants