Fix resources in containers #4498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Supol <jan.supol@oracle.com>
senivam
approved these changes
Jun 2, 2020
Tomas-Kraus
approved these changes
Jun 9, 2020
|
|
||
| <resources> | ||
| <resource> | ||
| <directory>${basedir}/src/main/java</directory> |
There was a problem hiding this comment.
Why do you have META-INF in src/main/java? I would move it to src/main/resources.
There was a problem hiding this comment.
this whole block is redundant and is being removed from Jersey...
There was a problem hiding this comment.
Yes, but still, things like META-INF shall be in src/main/resources.
| <resource> | ||
| <directory>${basedir}/src/main/resources</directory> | ||
| <filtering>true</filtering> | ||
| </resource> | ||
| </resources> | ||
| </build> | ||
|
|
||
| <profiles> | ||
| <profile> | ||
| <id>testsSkipJdk6</id> |
There was a problem hiding this comment.
Does it make sense to support such historical artifact like Java 1.6?
There was a problem hiding this comment.
probably that is why this profile is being removed...
There was a problem hiding this comment.
Yes. My fault, I somehow did not realize that this is "red". :)
This was referenced Jun 26, 2021
This was referenced Jul 6, 2021
This was referenced Aug 5, 2021
This was referenced Aug 30, 2021
1 task
This was referenced Oct 4, 2021
This was referenced Oct 18, 2021
This was referenced Oct 21, 2021
Merged
Merged
1 task
1 task
1 task
This was referenced Mar 7, 2022
This was referenced Mar 15, 2022
This was referenced Apr 17, 2022
This was referenced May 3, 2022
1 task
This was referenced Oct 19, 2022
1 task
This was referenced May 11, 2023
This was referenced Jun 15, 2023
1 task
1 task
This was referenced Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jan Supol jan.supol@oracle.com