Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regexp on MP RestClient @Path #4526

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Regexp on MP RestClient @Path #4526

merged 2 commits into from
Jul 8, 2020

Conversation

mcserra
Copy link
Contributor

@mcserra mcserra commented Jul 2, 2020

Solves #4348
Signed-off-by: Miguel Serra Miguel.Serra@criticaltechworks.com

@senivam senivam requested a review from Verdent July 3, 2020 06:08
@senivam
Copy link
Contributor

senivam commented Jul 3, 2020

Thanks for the PR. First of all I would like you take a look at Check Style notifications (in failed build on travis) and copyright year/headers adjustments. And also I would like to ask @Verdent to take a look at the PR.

@mcserra
Regexp on MP RestClient @path
ba14d86 
Signed-off-by: Miguel Serra <Miguel.Serra@criticaltechworks.com>
@mcserra
Copy link
Contributor Author

mcserra commented Jul 3, 2020 •
edited
Loading

Thanks. @senivam. I made the changes and the build still failed, but the error is not related to my changes, I guess

@senivam
Copy link
Contributor

senivam commented Jul 3, 2020

@mcserra now it's only technical issue, build will pass, thank you for fixes.

Verdent
Verdent approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@Verdent Verdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@senivam
Copy link
Contributor

senivam commented Jul 8, 2020

@mcserra please consider accepting PR to your branch 1, after that this PR can be merged

@senivam @mcserra
Copyright header
2c0099f 
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
@mcserra
Copy link
Contributor Author

mcserra commented Jul 8, 2020

Done! Thanks

@senivam senivam merged commit a05f5fb into eclipse-ee4j:master Jul 8, 2020
@jansupol jansupol added this to the 2.32 milestone Sep 22, 2020
This was referenced Jun 26, 2021
Merged
Open
Open
Merged
Open
This was referenced Jul 6, 2021
Merged
Closed
This was referenced Aug 5, 2021
Closed
Closed
This was referenced Aug 30, 2021
Closed
Merged
Merged
Merged
@renovate renovate bot mentioned this pull request Sep 6, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Oct 4, 2021
Merged
1 task
This was referenced Oct 21, 2021
Closed
Closed
Closed
Merged
This was referenced Nov 4, 2021
Merged
Closed
@renovate renovate bot mentioned this pull request Nov 20, 2021
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 10, 2022
Open
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Feb 5, 2022
Closed
1 task
This was referenced Mar 7, 2022
Closed
Closed
This was referenced Mar 15, 2022
Merged
Merged
This was referenced Apr 17, 2022
Closed
Closed
This was referenced May 3, 2022
Open
Open
@renovate renovate bot mentioned this pull request Sep 23, 2022
Merged
1 task
This was referenced Oct 19, 2022
Closed
Closed
@renovate renovate bot mentioned this pull request Feb 11, 2023
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Mar 26, 2023
Open
@renovate renovate bot mentioned this pull request May 11, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Jun 15, 2023
Merged
1 task
@renovate renovate bot mentioned this pull request Jul 6, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Aug 30, 2023
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 4, 2023
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 11, 2024
Open
This was referenced Apr 13, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senivam senivam senivam approved these changes

@Verdent Verdent Verdent approved these changes

Assignees

@mcserra mcserra

Labels
None yet
Projects
None yet
Milestone
2.32
Development

Successfully merging this pull request may close these issues.
4 participants
@mcserra @senivam @Verdent @jansupol