-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper handling of chunked input streams in LoggingInterceptor #4753
Proper handling of chunked input streams in LoggingInterceptor #4753
Conversation
Signed-off-by: Denis Kurochkin <d.k.brazz@gmail.com>
761d330
to
3d74396
Compare
Signed-off-by: Denis Kurochkin <d.k.brazz@gmail.com>
The PR looks good. What it does, though, enables to read all the chunks from the chunked stream. That is assumingly the preferred behaviour. I can imagine a case where people do not want to log all the chunks and want to log just the first one, the way it worked now. Perhaps for performance reasons, or to keep the log small. |
I think existing maxEntitySize should be enough to cover it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests, provided in the PR prove that maxEntitySize works as designed, so, functionality with restricted entity size is not affected. For me it looks good.
…se-ee4j#4753) Signed-off-by: Denis Kurochkin <d.k.brazz@gmail.com>
Fixes unexpected entity cutting in logs
#4034, #3306 and #3281