Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jdk connector dead lock #4821

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Jdk connector dead lock #4821

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea56d57
Deadlock reproducer
jbescos Jul 2, 2021
e737252
Remove unnecessary lock
jbescos Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .../src/main/java/org/glassfish/jersey/jdk/connector/internal/DestinationConnectionPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, 2019 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2021 Oracle and/or its affiliates. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0, which is available at
Expand Down Expand Up @@ -195,12 +195,11 @@ private void handleIllegalStateTransition(HttpConnection.State oldState, HttpCon
throw new IllegalStateException("Illegal state transition, old state: " + oldState + " new state: " + newState);
}

private synchronized void removeAllPendingWithError(Throwable t) {
for (RequestRecord requestRecord : pendingRequests) {
private void removeAllPendingWithError(Throwable t) {
RequestRecord requestRecord = null;
while ((requestRecord = pendingRequests.poll()) != null) {
requestRecord.completionHandler.failed(t);
}

pendingRequests.clear();
}

private class ConnectionStateListener implements HttpConnection.StateChangeListener {
Expand Down