Issue #4881 - Java client connector #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a basic implementation of a client connector using java.net.http.HttpClient Signed-off-by: Steffen Nießing <zuniquex@protonmail.com>
zUniQueX
force-pushed
the
java-httpclient-connector
branch
from
2295cce to
cfe3413
Compare
|
@senivam Should I convert the tests to standard assertions? I think AssertJ is more intuitive, but if all other assertions are standard JUnit assertions, I could update to those. |
|
@zUniQueX no-no, just leave it as is. Those dependencies will be approved and then your PR will be merged. It's OK, just wait a bit. Thank you :) |
jansupol
approved these changes
Dec 29, 2021
|
Merged in 2021 to prevent copyright issues |
|
related CQs are resolved |
This was referenced Nov 4, 2022
Merged
This was referenced Nov 20, 2022
1 task
This was referenced Jul 24, 2023
This was referenced Aug 14, 2023
1 task
This was referenced Sep 11, 2023
1 task
This was referenced Nov 25, 2023
1 task
This was referenced Jan 3, 2024
1 task
1 task
1 task
1 task
Closed
1 task
1 task
1 task
This was referenced Jul 9, 2024
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a basic implementation of a client connector using java.net.http.HttpClient
Signed-off-by: Steffen Nießing zuniquex@protonmail.com