Abort JettyRequest when the response Future is completed exceptionally #5109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the jettyRequest.abort() operation is actually performed. Current situation prevent this code to be ever called as only the chained CompletableFuture is completed.
senivam
approved these changes
Aug 1, 2022
jbescos
approved these changes
Aug 1, 2022
This was referenced Sep 6, 2022
1 task
This was referenced Sep 8, 2022
This was referenced Sep 18, 2022
This was referenced Sep 25, 2022
This was referenced Oct 19, 2022
This was referenced Nov 20, 2022
1 task
1 task
This was referenced Dec 7, 2022
Closed
1 task
This was referenced Jan 6, 2023
Merged
This was referenced Feb 11, 2023
Closed
1 task
This was referenced May 11, 2023
This was referenced Jun 1, 2023
This was referenced Jun 4, 2023
This was referenced Jun 15, 2023
This was referenced Jul 6, 2023
This was referenced Aug 28, 2023
This was referenced Jan 16, 2024
1 task
1 task
This was referenced Apr 13, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the parent 'responseFuture' CompletableFuture is completed.
This ensures that the jettyRequest.abort() operation is actually performed.
Current situation prevent this code to be ever called as only the chained CompletableFuture is completed.