-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test issues #5137
Fix test issues #5137
Conversation
f1a3963
to
cee2185
Compare
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@@ -16,13 +16,17 @@ | |||
|
|||
package org.glassfish.jersey.tests.integration.jersey4697; | |||
|
|||
import static org.mockito.Mockito.mock; | |||
import static org.mockito.Mockito.when; | |||
import static org.junit.Assert.assertEquals; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the latest version of the PR there are many redundant imports. Could you please clean them out?
And those imports, which are already in place (before any changes) should not be reformatted because when it comes to merges, reformatting brings unnecessary conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see notes in the code
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
bc8a36e
to
f236173
Compare
I was not able to reproduce it, but it looks some users are having issues with a couple of tests.
@jansupol it would be good if you can run both tests and provide me feedback about the results.