Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FORM_PARAM_CONSUMED warning #5208

Merged
merged 3 commits into from
Dec 7, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2012, 2019 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2012, 2022 Oracle and/or its affiliates. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0, which is available at
Expand Down Expand Up @@ -603,7 +603,11 @@ private void filterFormParameters(final HttpServletRequest servletRequest, final
final String name = (String) parameterNames.nextElement();
final List<String> values = Arrays.asList(servletRequest.getParameterValues(name));

formMap.put(name, keepQueryParams ? values : filterQueryParams(name, values, queryParams));
final List<String> filteredValues = keepQueryParams ? values : filterQueryParams(name, values, queryParams);

if (!filteredValues.isEmpty()) {
formMap.put(name, filteredValues);
}
}

if (!formMap.isEmpty()) {
Expand Down