Handle equals and hashCode on MicroProfile client proxies #5324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zUniQueX
force-pushed
the
microprofile-client-hashcode-equals
branch
2 times, most recently
from
fb5dcee
to
c528b94
Compare
…ler objects Signed-off-by: Steffen Nießing <zuniquex@protonmail.com>
zUniQueX
force-pushed
the
microprofile-client-hashcode-equals
branch
from
c528b94
to
7aa9d1b
Compare
jansupol
approved these changes
May 9, 2023
senivam
approved these changes
May 10, 2023
This was referenced Jun 23, 2023
1 task
This was referenced Jul 6, 2023
This was referenced Jul 16, 2023
This was referenced Jul 27, 2023
This was referenced Aug 21, 2023
1 task
1 task
1 task
1 task
This was referenced Nov 22, 2023
This was referenced Jan 16, 2024
1 task
This was referenced Apr 13, 2024
Open
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxies generated from the
RestClientBuilderImpldon't properly handleequalsandhashCode. Therefore clients cannot be stored in containers likeMap.This PR extends the
ProxyInvocationHandlerto implementequalsandhashCode. Those calls are forwarded to theInvocationHandlerobjects of the proxies (similar to what is done in theWebResourceFactory).