-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return null instead of throwing exception when querystring parameter is missing #5326
Return null instead of throwing exception when querystring parameter is missing #5326
Conversation
@jansupol i tried to supply a new PR under my personal account, where i signed the ECA. Is it because of the commit message not being in the format defined in https://www.eclipse.org/projects/handbook/#resources-source? |
At least the build succeeded and the ECA is ok. Any tips on where i would add a unit test? |
Sorry for the delay, still planning this for review for 2.40... |
The test...it depends, it could be in |
See #5260
Instead of throwing IllegalArgumentException when querystring parameter value is null (e.g. not present), just return null.
Throwing exceptions is expensive, especially when it's done for every querystring parameter that has no @DefaultValue (and is not present in the request querystring).
I'm still looking for a good place to add a unit test. Would ParamConverterInternalTest be it?