Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Jackson 2.15 #5409

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Adopt Jackson 2.15 #5409

merged 1 commit into from
Sep 20, 2023

Conversation

jansupol
Copy link
Contributor

@jansupol jansupol commented Sep 8, 2023

No description provided.

@jansupol jansupol force-pushed the jackson2.15.2 branch 2 times, most recently from fbce297 to 5db7803 Compare September 14, 2023 05:45
Signed-off-by: jansupol <jan.supol@oracle.com>
@jansupol jansupol merged commit e79aa53 into eclipse-ee4j:2.x Sep 20, 2023
1 check passed
@jansupol jansupol deleted the jackson2.15.2 branch September 20, 2023 12:17
<para>
If supported by Jackson provider, the default value can differ for each Jackson version. For instance,
Jackson 14 does not support this setting and the default value is <literal>Integer#MAX_VALUE</literal>,
Jackson 15.0 has the default value 5_000_000, Jackson 15.2 has the default value 20_000_000.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Jackson versions are 2.14 and 2.15 - there is no 14 or 15. The 20m limit was brought in in Jackson 2.15.1.

See https://github.com/FasterXML/jackson-core/blob/2.16/release-notes/VERSION-2.x

<section xml:id="mig-2.40-breaking-changes">
<title>Changes in Jackson</title>
<para>
Jersey 2.41 starts to support Jackson 15 which comes with default limitations for the length of parsed text,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, no Jackson v15 has ever been released

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it is 2.15

# SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
#

error.jackson.streamreadconstraints=Error setting StreamReadConstraints: {0}. Possibly not Jackson 15?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, no Jackson v15 has ever been released

<artifactId>jackson-14</artifactId>
<name>jersey-compatibility-jackson14</name>
<description>
Controls the backward compatibility with Jackson 14 environment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, no Jackson v14 has ever been released

@@ -44,6 +44,7 @@
<module>j-376</module>
<module>j-441</module>
<module>j-59</module>
<module>jackson-14</module>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, no Jackson v14 has ever been released

@jansupol jansupol self-assigned this Oct 18, 2023
@jansupol jansupol added this to the 2.41 milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't uptake jackson 2.15.0+ without taking into account its new StreamReadConstraints
4 participants