Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow @Priority for ExceptionMapper #5469

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Allow @Priority for ExceptionMapper #5469

merged 1 commit into from
Nov 22, 2023

Conversation

jansupol
Copy link
Contributor

Centralized working with @priority value.

@jansupol jansupol force-pushed the exceptionmapper.priorities branch from c76c88a to 3e62527 Compare November 17, 2023 11:30
jbescos
jbescos approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@jbescos jbescos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbescos
Copy link
Member

jbescos commented Nov 21, 2023 •
edited
Loading

Can we test also with resourceConfig.register(new HigherPriorityExceptionMapper(), 200); and resourceConfig.register(new LowerPriorityExceptionMapper(), 100);?. I think that priority number should override the @Priority.

@jansupol jansupol force-pushed the exceptionmapper.priorities branch from 52beb65 to d953a8c Compare November 21, 2023 12:12
@jansupol
Allow @priority for ExceptionMapper
ff452b9 
Centralized working with @priority value.

Signed-off-by: jansupol <jan.supol@oracle.com>
@jansupol jansupol force-pushed the exceptionmapper.priorities branch from d953a8c to ff452b9 Compare November 21, 2023 12:15
@jansupol jansupol merged commit 1c329c8 into eclipse-ee4j:2.x Nov 22, 2023
@jansupol jansupol deleted the exceptionmapper.priorities branch November 22, 2023 10:27
@jansupol jansupol added this to the 2.42 milestone Dec 13, 2023
@solrbot solrbot mentioned this pull request Mar 20, 2024
Closed
1 task
@ChristianHoesel ChristianHoesel mentioned this pull request Mar 21, 2024
Open
1 task
@renovate-bot renovate-bot mentioned this pull request Mar 21, 2024
Closed
1 task
@solrbot solrbot mentioned this pull request Mar 24, 2024
Closed
1 task
This was referenced Mar 29, 2024
Open
Open
This was referenced Apr 6, 2024
Closed
Open
Merged
This was referenced Apr 19, 2024
Closed
Closed
Open
This was referenced Apr 28, 2024
Merged
Closed
Open
Open
Open
Open
@renovate renovate bot mentioned this pull request May 3, 2024
Open
1 task
@solrbot solrbot mentioned this pull request Jul 22, 2024
Closed
1 task
This was referenced Jan 9, 2025
Closed
Closed
This was referenced Jan 24, 2025
Open
Open
This was referenced Feb 4, 2025
Closed
Closed
Closed
@renovate renovate bot mentioned this pull request Feb 18, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbescos jbescos jbescos approved these changes

@senivam senivam senivam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.42
Development

Successfully merging this pull request may close these issues.
3 participants
@jansupol @jbescos @senivam